search

memononen / fontstash

Light-weight online font texture atlas builder
zlib License
688 stars 88 forks source link

align member of fontstash_style + gcc/clang warnings #4

Closed aktau closed 11 years ago

aktau commented 11 years ago

I've been adding warning flags in the Makefile and of course some stuff rolls out here and there. For example the align member of fontstash_style doesn't seem to be used anywhere (nor initialized). Is that meant to be? Or is that some sort of reminder to you that it still needs to be implemented?

Would you like to make the project as pedantic-free as possible or would you rather keep it simple?

The reason I ask is because in my project I mostly turn the warnings up to 11, so when I include external files they usually trigger a bunch of things, I like to fix it at the root if possible.

I'd also like to add a static analyzing target in the makefile for the LLVM static analyzer, which has helped me track down a lot of stuff in the past (to show that I'm not entirely crazy, John Carmack seems to agree with me :)).

If you're not ok with any of these things, then that's cool of course! I'll be just as happy to maintain a personal fork :).

memononen commented 11 years ago

At one point I was working on adding text alignment as part of the style, and I think I forgot that there.

It is relatively simple piece of code, so I think turning on more warnings makes sense and makes it easier to drop in.

Static analysis sounds goo, go ahead.

I try to hack out more examples so that I can settle on an API and start writing documentation.

memononen commented 11 years ago

Closing this at the other PR improve these issues.