search

memononen / nanosvg

Simple stupid SVG parser
zlib License
1.69k stars 357 forks source link

fix build using Watcom #192

Open sezero opened 3 years ago

sezero commented 3 years ago

PING?

oehhar commented 3 years ago

Dear sezero, THank you for your contribution. This is appreciated.

AFAIK only bugfixes are accepted to nanosvg. I suppose you should clearly state why your proposed change is a bugfix, as this is not obvious (for me).

And it would not harm to be a bit friendly.

Thank you again, Harald

oehhar commented 3 years ago

Don't take it from the wrong side. I would love to have this change in, as I also use a non C99 compatible compiler (MS-VC6). But this is not in the scope of the project.

Thank you, Harald

sezero commented 3 years ago

This is for making nanosvg to compile using OpenWatcom: It doesn't accept non-const array initializers or declarations after statements.

If this is not acceptable, feel free to close this.

sezero commented 3 years ago

And it would not harm to be a bit friendly.

I wasn't aware that I was unfriendly.

oehhar commented 3 years ago

Ozkan, sorry, I am not the maintainer. I just try to help to get this in. So explaining why you want that would help. Thats all.

And beeing friendly is on the level, that the programmer gave this gem for free and probably has invested monthes of his spare time. So starting with "thank you for the great software" would eventually be appropriate.

Thank you, Harald

sezero commented 3 years ago

PING?

sezero commented 2 years ago

PING? This is just a trivial C89-compatibility patch..