memononen / nanosvg

Simple stupid SVG parser
zlib License
1.71k stars 363 forks source link

Fix for typos, GCC warnings and shape ordering #83

Closed daniel-starke closed 7 years ago

daniel-starke commented 7 years ago

Optimizations made by #81 implemented a broken list reverse algorithm. This pull request fixes this together with typos' in comments and some GCC warnings (-Wconversion, -Wcast-qual, -Wpedantic, -Wunused-variable). I have tested the applied changes successfully.

memononen commented 7 years ago

Good fixes. I'd like to use the tail caching from #82 instead of reverse. Let's wait @lieff to update the PR, and can you try to base your's on that?

daniel-starke commented 7 years ago

I have applied the changes from #82 and tested the result. Looks good as far as I can see.

memononen commented 7 years ago

Merged, thanks for the fixes!