search

memorysafety / river

This repository is the home of the River reverse proxy application, based on the pingora library from Cloudflare.
https://www.memorysafety.org/initiative/reverse-proxy/
Apache License 2.0
1.9k stars 107 forks source link

Provide a root workspace #20

Closed jamesmunns closed 7 months ago

jamesmunns commented 7 months ago 
          I've juste seen you starting development.

I hope you're enjoying getting into development.

I'm pulling your branch, to read over my lunch. I realised that my IDE couldn't analyse the code with rust-analyzer. So I found a trick to do it.

I add a root Cargo.toml to reference the repository member project.

[workspace]

members = [
    "source/river",
]

I don't know if you're used to doing this. Just a suggestion.

Thank you for your time and your work. I wish you a good day.

Originally posted by @lperdereau in https://github.com/memorysafety/river/issues/19#issuecomment-2036934124

jamesmunns commented 7 months ago

@lperdereau moving this to a new issue as it is off topic for the other PR.

Thanks for the report! Yes, you'll need to launch from the source/river folder for now, we could consider adding a top level workspace to allow for this as you've mentioned. If you'd like to open this as a PR I'd accept it.

lperdereau commented 7 months ago

Oh yeah excuse me. I will do the job to close this issue :+1: