memorysafety / river

This repository is the home of the River reverse proxy application, based on the pingora library from Cloudflare.
https://www.memorysafety.org/initiative/reverse-proxy/
Apache License 2.0
1.72k stars 101 forks source link

Investigate relative paths for `pid-file` and `upgrade-socket`s #50

Open jamesmunns opened 2 months ago

jamesmunns commented 2 months ago

In #49, I had issues when specifying relative paths. I'd like to dig in a bit and figure out if this is an issue from pingora, or how I am holding it.

jamesmunns commented 2 months ago

Opened https://github.com/cloudflare/pingora/issues/331 - this is likely something to be resolved in pingora. For now, we should return an error when validating configuration if a relative path is specified for either of these items.