Closed JonasKruckenberg closed 1 month ago
Attention: Patch coverage is 95.23810%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 90.60%. Comparing base (
751c803
) to head (91ddd87
).:exclamation: Current head 91ddd87 differs from pull request most recent head 81c3a2e. Consider uploading reports for the commit 81c3a2e to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I made it so that cargo check
at least works for --target thumbv7em-none-eabihf
now with the zlib-rs
crate itself. If you're OK with some API breakage in the future that should provide everything you need to play around with this I think.
But maybe not, let me know. Also
cargo check --target thumb*
provide enough stability?turns out I can force push. I think this is ready to merge, but would like to try it out on actual embedded hardware just to make sure there are no unexpected issues. I'll try to do that tomorrow
As promised: This PR adds
no_std
support tozlib-rs
, by adding two new feature flagsstd
andalloc
that hide related functionality behind them (enabled by default).I also had to disable the auto-detection of features which is not yet exposed through feature flags.