memphis-iis / datawhys-content-notebooks-python

Content for DataWhys in the form of JupyterLab notebooks (.ipynb files)
Apache License 2.0
8 stars 2 forks source link

Confusing bit in Crossvalidation.ipynb #132

Open sdflem opened 11 months ago

sdflem commented 11 months ago

This item was confusing to at least one intern (and I could imagine it confusing more):

  • Set it to with pipe create Pipeline using a list containing

Because the "list" actually needs to be an array-type list (not just a list of arguments).

I note that this is doubly confusing because some other instructions in the notebook use the same language ("a list") to refer simply to a list of args.

aolney commented 1 month ago

Apologies for delay, I never got a notification on this one.

My understanding is that the instruction here is correct but is confusing because other instructions are inconsistent.

I updated all argument type instructions when we added dynamic arguments to the intelliblocks. So I'll need some help identifying any that I missed.