memphis-iis / mofacts

8 stars 1 forks source link

Missing correct and incorrect feedback messages during drill trials #1357

Closed Wei940127 closed 11 months ago

Wei940127 commented 11 months ago

I used the following codes and found no correct or incorrect feedback messages were displayed, either indicating correctness or incorrectness, during drill trials after participants entered their responses. image Here is the interface I've got after both correct and incorrect attempts. Missing part of feedback

Below are the interfaces I'd like to use for the experiment which indicate correct and incorrect attempts. Could you help me with it? Thanks! correct interface incorrect interface

imrryr commented 11 months ago

We need to make sure we are using staging and production correctly. Maybe we should make sure all the changes from the various issues go to staging, and then test and do a production deploy next week? @JRustyHaner @MegaGeese Thanks!

imrryr commented 11 months ago

@Wei940127 Please supply the uisettings json in json, not an image please. images are hard to copy and test.

Wei940127 commented 11 months ago

Below are the files I used for the test. HighMTestPractice (7).zip

Here are the codes for the UI setting.

            "uiSettings": {
              "displayReviewTimeoutAsBarOrText": "false",
              "displayReadyPromptTimeoutAsBarOrText": "false",
              "displayCardTimeoutAsBarOrText": false,
              "displayTimeOutDuringStudy": false,
              "displayUserAnswerAtTop": false,
              "displayPerformanceDuringStudy": true,
              "displayCorrectAnswerInCenter": true,
              "displayUserAnswerInFeedback": true,
              "onlyShowSimpleFeedback": false,
          "stimuliPosition":"left",
              "incorrectColor": "darkorange",
              "correctColor": "green"
            }
JRustyHaner commented 11 months ago

@Wei940127 @imrryr

This is an old UISettings specification. We can troubleshoot any issues that come up after the json is changed. Please use the following options and tailor them to your needs:

  "displayReviewTimeoutAsBarOrText": "both"
  "displayReadyPromptTimeoutAsBarOrText": "both",
  "displayCardTimeoutAsBarOrText": "both",
  "displayTimeOutDuringStudy": true,
  "displayUserAnswerInFeedback": true,
  "displayPerformanceDuringStudy": false,
  "displayPerformanceDuringTrial": true,
  "displayCorrectAnswerInCenter": false,
  "singleLineFeedback" : false,
  "feedbackDisplayPosition" : "middle",
  "stimuliPosition" : "top",
  "choiceButtonCols": 1,
  "onlyShowSimpleFeedback": false,
  "incorrectColor": "darkorange",
  "correctColor": "green"
Wei940127 commented 11 months ago

Thank you. I modified the above codes to control the display of drill trials in the assessment unit.

                        "displayReviewTimeoutAsBarOrText": "false",
                        "displayReadyPromptTimeoutAsBarOrText": "false",
                        "displayCardTimeoutAsBarOrText": "false",
               "displayTimeOutDuringStudy": false,
                       "displayUserAnswerInFeedback": true,
                        "displayPerformanceDuringStudy": false,
                        "displayPerformanceDuringTrial": true,
                        "displayCorrectAnswerInCenter": true,
                        "singleLineFeedback" : true,
                        "feedbackDisplayPosition" : "middle",
                        "stimuliPosition" : "left",
                        "onlyShowSimpleFeedback": false,
                        "incorrectColor": "darkorange",
                        "correctColor": "green"

The typing bar was missing during the drill trials, please see the below image. Also, no correct or incorrect feedback messages were shown. missing typing bar

JRustyHaner commented 11 months ago

@imrryr @Wei940127 We have a pull request for this issue.

The UI Settings are now correct.

imrryr commented 11 months ago

@JRustyHaner @MegaGeese So can we plan to deploy tomorrow to staging with all current changes, please?

JRustyHaner commented 11 months ago

@imrryr Sure, when all the PRs are pulled in.

imrryr commented 11 months ago

Right, thank you..

On Thu, Jan 4, 2024, 9:43 AM JRustyHaner @.***> wrote:

@imrryr https://github.com/imrryr Sure, when all the PRs are pulled in.

— Reply to this email directly, view it on GitHub https://github.com/memphis-iis/mofacts/issues/1357#issuecomment-1877314110, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLPK3H2C5H6URS3TRW6UTYM3EZXAVCNFSM6AAAAABBKPR65KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGMYTIMJRGA . You are receiving this because you were mentioned.Message ID: @.***>

Wei940127 commented 11 months ago

I just tested it and the feedback display worked correctly. image But the typing bar still missing. image

JRustyHaner commented 11 months ago

@imrryr @Wei940127 closing this as complete

imrryr commented 11 months ago

@JRustyHaner It seems you closed this. Did you want another issue created or can we respond to Wei's reply here. She posted it to minutes before you closed it and I'm guessing you didn't see it when you closed it.

imrryr commented 11 months ago

@Wei940127, please provide the zip file in case Rusty needs it

Wei940127 commented 11 months ago

Sure. Here is the file. Thank you! HighMTestPractice13.zip

JRustyHaner commented 11 months ago

@imrryr I'll just work off of this issue request