search

memphis-iis / mofacts

8 stars 1 forks source link

Unti 12 worked, but Unit 11 produced this failure #1398

Closed imrryr closed 9 months ago

imrryr commented 10 months ago

It is mentioning video units, but Unit 11 is normal content, no videos. This happens immediately on start. @MegaGeese

image

JRustyHaner commented 10 months ago

@imrryr could you send me unit 11's package please?

JRustyHaner commented 10 months ago

@imrryr also for some reason I cannot reproduce this error with a fresh account.

imrryr commented 10 months ago

@JRustyHaner it still happens for me. I can bring my computer later. I think it seemed associated with how the uploader failed when I uploaded it #1397 unit11.zip

JRustyHaner commented 10 months ago

@imrryr I'll look into it. The variable in question is the current unit number. On line 3307, Session.get('currentTdfFile').tdfs.tutor.unit[Session.get('currentUnitNumber')] returns undefined since Session.get('currentUnitNumber')] is sometimes set to 1, and that tdf only appears to have a unit 0.

imrryr commented 10 months ago

When a tdf completes, it should retain the unitnumber in the database. If 0 is first unit, if I did 11 on that user with the old version that user will be set to 1, which would result in the tdf not running.... That is expected behavior.

However, that is not what production is doing, currently on production it seems to be not incrementing the unit number and students can run the same prequiz twice... perhaps it doesn't increment the unit number if there is no next unit? It really should otherwise this unintended rerunning of experiments becomes possible @JRustyHaner

imrryr commented 10 months ago

So basically I would not have reported this unless I had become used to what I might have considered a bug. Basically this is a problem with the resume function because if a user completes a unit, it should not restart with that unit. (though it should restart if the unit is not complete of course as usual)

JRustyHaner commented 10 months ago

@imrryr FYI the current unit number session variable is only set at the end of the previous unit or a resume from component state, or when a user navigates away from the page.

imrryr commented 10 months ago

@JRustyHaner what are the implications of that relative to what I said?

imrryr commented 10 months ago

We have to load the current unit number on each tdf start

JRustyHaner commented 10 months ago

@imrryr did you happen to encounter a continue button that you used on card? This button is attached to unitIsFinished('Continue Button Pressed'); which increments the current unit number

imrryr commented 10 months ago

huh? the practice just ends in assessment sessions.... (like the prequiz)

JRustyHaner commented 10 months ago

@imrryr just exploring avenues. I can't reproduce it on this end with the existing deployment on staging or on a local copy, but I've seen this error before. It's intermittent it seems, so I'm trying to figure out the exact condition that causes it.

imrryr commented 10 months ago

Well we're meeting in person at 3:00 and so why don't we look at my computer then because it still produced it.

On Wed, Feb 7, 2024, 11:53 AM JRustyHaner @.***> wrote:

@imrryr https://github.com/imrryr just exploring avenues. I can't reproduce it on this end with the existing deployment on staging or on a local copy, but I've seen this error before. It's intermittent it seems, so I'm trying to figure out the exact condition that causes it.

— Reply to this email directly, view it on GitHub https://github.com/memphis-iis/mofacts/issues/1398#issuecomment-1932579338, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLPK74ERMEASEDNGCNQPTYSO5TDAVCNFSM6AAAAABC242XHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGU3TSMZTHA . You are receiving this because you were mentioned.Message ID: @.***>

imrryr commented 9 months ago

well, so does that imply that it can't resume an assessment session since after the instructions any resume will go to the next unit? I think we used to save the progress in the schedule, and resumed the schedule

imrryr commented 9 months ago

@JRustyHaner, but I don't want to fix that now. My content uploader is broken, and the other issues is that it causes a blank screen and error message about video in the console. Lets not have this become more now please. Feel free to explain other things for future issues, but right now I just want a working uploader and the graceful termination of completed units.

JRustyHaner commented 9 months ago

@imrryr Very well, I have a PR up.