search

memphis-iis / mofacts

8 stars 1 forks source link

Change unit template location to setspec #1520

Closed MegaGeese closed 1 month ago

MegaGeese commented 1 month ago

Make it possible to run unti templates in between defined units.

imrryr commented 1 month ago

Why is this necessary? It confuses me. There should be no object types other than units in a tdf. We can make the unit template blocks units themselves, yes? That would solve it

On Thu, Jul 18, 2024 at 1:52 PM August White @.***> wrote:

Make it possible to run unti templates in between defined units.

— Reply to this email directly, view it on GitHub https://github.com/memphis-iis/mofacts/issues/1520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLPK7NHC2NZ63UKK3BONTZNAFIDAVCNFSM6AAAAABLDHYBS6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTOMJWGA3DGNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Dr. Philip I. Pavlik Jr.

Associate Professor | Cognitive Area Graduate Director

Institute for Intelligent Systems and Psychology Dept.

Pronouns: he, they

[image: UofM logo]

The University of Memphis 400 Innovation Drive, Psychology Bldg. Memphis, TN 38152

901.678.2326 | optimallearning.org

[image: UofM Facebook] https://www.facebook.com/uofmemphis [image: UofM Instagram] https://www.instagram.com/uofmemphis/

JRustyHaner commented 1 month ago

@imrryr the problem with having unit templates inside the unit array is that mofacts iterates over units by index, so anything in the unit array will be displayed as a unit to the user.

There are two solutions that I see here.

We add a option in unit templates that defines where the unit should appear (after what index) , or your solution and add a option defining that unit as a template and removing it from the schedule until the logic adds it.

(Also, I just got back, so if this isn't what you discussed, ignore this)

imrryr commented 1 month ago

@JRustyHaner @MegaGeese I'm just concerned with increasing the complexity of MoFaCTS. I'm not understanding why the unittemplate information requires changing a characteristic of the system that has persisted more than 10 years (having only units). Other than the setspec, I'd really like the units to be self contained. We can discuss this at our meeting today.

JRustyHaner commented 1 month ago

@imrryr sure, we can chat about it this afternoon. Complexity is definitely a concern. Thankfully most, if not all, of the adaptive system is in a class that doesn't run unless the unit has a specific tag. Makes it a lot less easy for adaptive bugs to affect you.