imrryr
commented
2 months ago Perhaps we could detect if there was a key in the tdf and produce a warning. Perhaps we could disallow sharing of tdf is there is a key detected and tell the user the tdf must be shared manually in such cases for security reasons
On Tue, Sep 24, 2024 at 3:06 PM JRustyHaner @.***> wrote:
Assigned #1569 https://github.com/memphis-iis/mofacts/issues/1569 to @imrryr https://github.com/imrryr.
— Reply to this email directly, view it on GitHub https://github.com/memphis-iis/mofacts/issues/1569#event-14387895848, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLPK2DZHHIIKC2SQCZMYTZYHA3PAVCNFSM6AAAAABOZBTGSSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGM4DOOBZGU4DIOA . You are receiving this because you were assigned.Message ID: @.***>
-- Philip I. Pavlik Jr. @.*** http://optimallearning.org/
Describe the bug It's pretty inefficient to store Google API keys in a separate mongo collection. We should attach them to the TDF. We also should try to remove any client side calls to retrieve the Key, since Google API should only be called server side with the results sent to the client.
Expected behavior Google API keys should be inside the TDF (where that key is used at the tdf level) or at the class level (where classes share a TDF based off of their teacher).
Discussion Requested Some discussion might be necessary, since teachers might be assigning someone elses TDFs and may inadvertently use the tdf owner's keys instead of their own, increasing costs to the TDF owner.