search

memphis-iis / mofacts

8 stars 1 forks source link

saveUsersFile Method is ambiguously named #1571

Closed JRustyHaner closed 3 weeks ago

JRustyHaner commented 3 weeks ago

Describe the bug Line 2922 of methods. saveUsersFile is intended to mass register a set of users and their passwords. The name saveUsersFile is a bit ambiguous as well.

To Reproduce Steps to reproduce the behavior:

  1. Go to user admin page,
  2. browse a csv
  3. click upload user file

Expected behavior A new set of users are imported to Meteor's user collection.

Discussion Save is pretty ambiguous. Perhaps 'export' and 'import' are better terms to use.

JRustyHaner commented 3 weeks ago

Looked like there was a bug here, it's just a weird artifact in the linter.