memphis-iis / mofacts

8 stars 1 forks source link

Crash before first trial #532

Closed imrryr closed 2 years ago

imrryr commented 2 years ago

Describe the bug Works up to content delivery mofacts_app and 11 more pages - Personal - Microsoft​ Edge 1_28_2022 2_21_40 PM

imrryr commented 2 years ago

Confirmed with old tdf, can't run trials until fixed

JRustyHaner commented 2 years ago

@imrryr the answers are not in the syllable database. I fixed neurons, but ranvier isn't in there either, which was my next question. As a fallback, I can default to hintlevel 0 for answers that are not in the dictionary.

imrryr commented 2 years ago

But I didn't use a new stim file? Why did this happen now?

imrryr commented 2 years ago

Your answer is a fine solution though. Please implement it so the system has fallback. I'm adding Andrew O to this to see if we can find more syllable information.

imrryr commented 2 years ago

Even if more syllables can be produced, we need the fallback in place today to continue testing on schedule. We need to be testing the full system soon otherwise we will encounter problems with delivery.

JRustyHaner commented 2 years ago

@imrryr I've added the fallback, it didn't happen in the past because of the full implementation of hint levels.

JRustyHaner commented 2 years ago

@imrryr also, it might be a good idea to find a fallback syllable dictionary so that if there is a word that is not in the dictionary, we can still produce some hint data.

imrryr commented 2 years ago

Please tell me when it is running on staging. Andrew O will be our expert on syllable sources @aolney

JRustyHaner commented 2 years ago

I'll build it as soon as Rhodes reviews it. I want to get testing started.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Philip Pavlik @.> Sent: Monday, January 31, 2022 9:33:29 AM To: memphis-iis/mofacts-ies @.> Cc: James Russell Haner (jrhaner) @.>; Assign @.> Subject: Re: [memphis-iis/mofacts-ies] Crash before first trial (Issue #532)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and trust the content is safe.

Please tell me when it is running on staging. Andrew O will be our expert on syllable sources @aolneyhttps://github.com/aolney

— Reply to this email directly, view it on GitHubhttps://github.com/memphis-iis/mofacts-ies/issues/532#issuecomment-1025902137, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALEINDON5BP34KYBMPY7LSTUY2TUTANCNFSM5NBV2PKQ. You are receiving this because you were assigned.Message ID: @.***>

JRustyHaner commented 2 years ago

Building now

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Rhodes White @.> Sent: Monday, January 31, 2022 9:39:55 AM To: memphis-iis/mofacts-ies @.> Cc: James Russell Haner (jrhaner) @.>; Assign @.> Subject: Re: [memphis-iis/mofacts-ies] Crash before first trial (Issue #532)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and trust the content is safe.

Closed #532https://github.com/memphis-iis/mofacts-ies/issues/532 via #533https://github.com/memphis-iis/mofacts-ies/pull/533.

— Reply to this email directly, view it on GitHubhttps://github.com/memphis-iis/mofacts-ies/issues/532#event-5981718561, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALEINDOL5HUIWOPU3W3OE2DUY2UMXANCNFSM5NBV2PKQ. You are receiving this because you were assigned.Message ID: @.***>

JRustyHaner commented 2 years ago

@imrryr deployed