memphis-iis / mofacts

8 stars 1 forks source link

Stim generation error #946

Closed imrryr closed 1 year ago

imrryr commented 1 year ago

Describe the bug Error in stim generation,

"correctResponse": "."

will need new fixed files that don't allow "." as a response

"stims": [ { "response": { "correctResponse": "." }, "display": { "clozeStimulus": "From__there__they__pass__into__the__auditory__cortices__of__the__temporal__lobes__of__the__cerebrum, where__they__are__interpreted." }, "parameter": "0,.80", "tags": { "weightGroup": 3, "orderGroup": 4, "sentenceWeight": 30, "clozeProbability": 1, "corefClusters": 2, "corefClusterTotalWeight": 30, "corefClusterBackwardWeight": 3, "corefClusterForwardWeight": 23, "rootDistance": 1, "startDistance": 20, "stimulusId": 536985279, "clusterId": -497599541, "transformation": "none" } }, { "response": { "correctResponse": "." }, "display": { "clozeStimulus": "From__there, they__pass__into__the__auditory__cortex__of__the__early__lobes__of__the__brain, where__they__are__interpreted." }, "parameter": "0,.80", "tags": { "weightGroup": 3, "orderGroup": 4, "sentenceWeight": 30, "clozeProbability": 1, "corefClusters": 2, "corefClusterTotalWeight": 30, "corefClusterBackwardWeight": 3, "corefClusterForwardWeight": 23, "rootDistance": 1, "startDistance": 20, "stimulusId": -847164254, "clusterId": -497599541, "transformation": "paraphrase" } } ] },

aolney commented 1 year ago

This only occurs in this one file (I just searched all stim files), specifically two items off the same sentence in chapter 12

I don't fully understand what's happening with the blanks, but the problem seems to be driven by the parser assigning a weird structure to the sentence.

Rather than fiddle with the parser, which could cause unintended consequences for other items, I suggest we manually edit out the items involved.

aolney commented 1 year ago

I've got a patch in that prevents this from happening; I can either re-run the stim files or we can manually edit the 2 items out, just let me know

imrryr commented 1 year ago

Ok, I'll edit those 2 stims out

On Wed, Sep 7, 2022, 4:16 PM Andrew M Olney @.***> wrote:

I've got a patch in that prevents this from happening; I can either re-run the stim files or we can manually edit the 2 items out, just let me know

— Reply to this email directly, view it on GitHub https://github.com/memphis-iis/mofacts-ies/issues/946#issuecomment-1239893126, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDLPK7DYVUA4CS43VNCKOLV5EA3LANCNFSM6AAAAAAQGZ23KA . You are receiving this because you authored the thread.Message ID: @.***>