search

memspace / zefyr

Soft and gentle rich text editing for Flutter applications.
https://zefyr-editor.gitbook.io
2.22k stars 550 forks source link

Removed _sentRemoteValues #554

Closed Amir-P closed 3 years ago

Amir-P commented 3 years ago

This PR attempts to fix these issues:

Nov-13-2021 12-58-07

https://user-images.githubusercontent.com/8766492/141613606-4bbe9a7f-14c0-4e1b-9a65-fde8e0b82880.MP4

https://user-images.githubusercontent.com/8766492/141613649-b58de377-6fa3-46d7-b740-c6f1606721ef.mp4

Though I've done some basic tests and it's seems to be working fine on both Android and iOS, I'm not aware of side effects removing _sentRemoteValues can have since I'm not sure why it was even added.

pulyaevskiy commented 3 years ago

Thanks for the PR. I'm a bit hesitant removing this workaround entirely as it serves a specific purpose described in the comment.

I'll look into referenced issues a bit closer and see if there is an alternative solution, or if this workaround is no longer needed or can be improved.