search

memsql / dbbench

Database Benchmark Tool
Apache License 2.0
156 stars 32 forks source link

Cannot connect to Postgres after #14 #15

Closed antiguru closed 2 years ago

antiguru commented 3 years ago

I cannot connect to Postgres after #14 was merged:

~/go/bin/dbbench -driver postgres -username materialize -database materialize -port 6875 select_latency.ini                                                                                                                                                
2021/10/04 11:35:51 Connecting to postggresql://materialize:@localhost:6875/materialize                                                                                                                                                                                              
2021/10/04 11:35:51 Error connecting to the database: missing "=" after "postggresql://materialize:@localhost:6875/materialize" in connection info string"

Reverting to bbf9ecdb088095ff43361c7c25655d5b71fc5e3f avoids the problem.

ruw commented 2 years ago

Hi, thanks for reporting this. I'm not able to reproduce this and can still successfully run dbbench with postgres. Could you share more details to help repro?

Not sure if it's relevant, but it also looks like your connection string has a typo (postggresql instead of postgres).

antiguru commented 2 years ago

Thanks for checking. I'll try to see if the issue still reproduces next week and will update this issue accordingly.

antiguru commented 2 years ago

Alright, finally go around to checking this problem. You're correct that the problem does not reproduce on head. Please close this issue at your convenience. I figured what confuses me, but it might just be my lack of experience with go:

$ go get github.com/memsql/dbbench
go: downloading github.com/memsql/dbbench v0.3.1
go: downloading github.com/go-sql-driver/mysql v1.6.0
go: downloading github.com/denisenkom/go-mssqldb v0.11.0
go: downloading github.com/lib/pq v1.10.4
go: downloading github.com/awreece/goini v0.0.0-20170814002257-6b3ccd8204f1
go: downloading golang.org/x/net v0.0.0-20211118161319-6a13c67c3ce4
go: downloading github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe
go: downloading golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c
go get: installing executables with 'go get' in module mode is deprecated.
        Use 'go install pkg@version' instead.
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

The interesting bit is that it should download version 0.4, but in fact it picks 0.3.1. Building from source produces a working copy of dbbench.

ruw commented 2 years ago

Thanks for confirming