search

memsql / memsql-docker-quickstart

A docker image for testing MemSQL + MemSQL Ops
Apache License 2.0
67 stars 23 forks source link

Feature Request: Flag to ignore min system requirements #10

Closed cricketts closed 7 years ago

cricketts commented 7 years ago

Hello,

By default MemSQL requires 4 CPU cores and 8 GB RAM which makes sense for performance reasons. However I would like to run this Dockerized version of MemSQL on TravisCI as part of a simple continuous integration test where load is minimal and performance isn't critical.

I only have 2 cores available on Travis which currently prevents me from starting MemSQL. I see that there's a --ignore-min-requirements flag which seems perfect:

https://help.memsql.com/hc/en-us/articles/115001215583-My-hosts-have-less-than-minimum-MemSQL-system-requirements-How-can-I-make-MemSQL-run-on-those-hosts-

If I am not mistaken this can easily be added as an option during the setup phase here:

https://github.com/memsql/memsql-docker-quickstart/blob/5f5d7e7887893bd03d42e8ecc7d65c570964f661/setup.sh#L24

Can you expose this --ignore-min-requirements option at the Docker level?

cricketts commented 7 years ago

Digging into this more, it appears that the --ignore-min-requirements flag is only used during installation (which only affects developers). Really the minimum_core_count and minimum_memory_mb variables need to be set -- this can either be done while building the Docker image or at runtime.

I'm going to take a stab at this and expose it as an environment variable while starting up the Docker container. I hope PRs are welcome here!

cricketts commented 7 years ago

Closed by https://github.com/memsql/memsql-docker-quickstart/pull/11