search

memsql / memsql-docker-quickstart

A docker image for testing MemSQL + MemSQL Ops
Apache License 2.0
67 stars 23 forks source link

Add runtime option IGNORE_MIN_REQUIREMENTS to ignore system requirements check #11

Closed cricketts closed 7 years ago

cricketts commented 7 years ago

This change exposes an IGNORE_MIN_REQUIREMENTS Docker environment variable that allows the user to disable the minimum system requirements check. Per this MemSQL article this is not a recommended practice for development or production. I've added this caveat in the README so users are informed before choosing to ignore this check.

Implements https://github.com/memsql/memsql-docker-quickstart/issues/10

I don't believe this should be merged into master but I didn't see an unreleased branch. Let me know if this is a feature you're willing to accept and if there's a different approach you'd rather see.

Thanks for your time.

carlsverre commented 7 years ago

Thanks for the contribution @cricketts! This looks great. I will get back to you soon about merging this in - but it should be good to go into master. I like that it's optional and explicit - both good properties. Will update soon with details about merging it in - legal may want you to sign a CLA, not sure yet.

carlsverre commented 7 years ago

Thanks for the pull-request Cricketts! I am going to ship a new version of the image today.

carlsverre commented 7 years ago

Pushed as latest and 5.8.7-2

cricketts commented 7 years ago

Awesome thanks so much @carlsverre!

rvaisbort commented 7 years ago

Hi Cricketts, for us to incorporate your contribution, our practice is to enter into a CLA. It's a pretty friendly form - Contributor License Agreement 2017.09.18 (1).docx please take a look and sign/return if you'd like us to proceed.

Thanks, Ron