Update library to support mysqlclient>=1.4.0

memsql / memsql-python

This repository holds some python libraries and plugins designed to be used with MemSQL.

MIT License

62 stars 33 forks source link

Closed arikfr closed 4 years ago

arikfr commented 5 years ago

In version 1.4.0 of mysqlclient they moved the _mysql module into the MySQLdb package (PyMySQL/mysqlclient-python#293).

Will you be interested in accepting a pull request that adds support for this version of mysqlclient? It can be done in a backward compatible way:

try:
    import _mysql
except ImportError:
    from MySQLdb import _mysql

arikfr commented 5 years ago

It looks like it will require an update in memsql.common.conversions as well, as the current code assumes converters are arrays.

carlsverre commented 4 years ago

Sorry for the huge delay on this - please check it out and let me know if you run into any issues.