search

menan / SparkJson

JSON library Ported from @bblanchon for Spark Core
MIT License
36 stars 15 forks source link

Library broken with updated firmware? #2

Open dhhagan opened 7 years ago

dhhagan commented 7 years ago

On the Particle IDE, it lists this library as broken on all platforms. When I try to compile through the IDE, it seems to throw errors associated with type casts.

Ex. Using the example from the glowfish httpsclient library:

top['coreid'] = (const char*) System.deviceID();

error: invalid conversion from int to ArduinoJson::JsonObject::key_type()

ScruffR commented 7 years ago

It's not actually the lib, but the include statements in the examples

// this is the original
//#include <ArduinoJson.h>
// but should be this
#include "SparkJson/ArduinoJson.h"

See community thread https://community.particle.io/t/issues-with-compiling-the-sparkjson-library/28242

dhhagan commented 7 years ago

Awesome!

ScruffR commented 7 years ago

I think this issue should still be addressed, so could you reopen it again?