menchelab / BioProfiling.jl

A flexible Julia toolkit for high-dimensional cellular profiles
MIT License
13 stars 1 forks source link

Boolean subset of Selectors #4

Closed koalive closed 4 years ago

koalive commented 4 years ago

Selectors implemented in c56fad2d8a5fb23c0b31c0f516ae39b538c8a61a allow to perform a test on a subset of the entries (rows), when provided with an array of indices of entries to consider. Accepting an array of booleans (indicating whether each entry should be kept or skipped) would be an improvement.
Technical note: subset would then be an Array{Bool,1} which is itself an Array{Number,1}, but this means that the elements of the array are cast to Number leading to a BoundsError when used to subset entries. The issue is similar to [4,7,3][Number[true,false,true]].

koalive commented 4 years ago

Problem not relevant as of 2f910cbce4b350b113d484f134546c442c0df67d as the subsets are now passed as a function and calculated only when the Selector is applied.