mend / renovate-ce-ee

Mend Renovate Documentation & Examples
https://www.mend.io/renovate/
Other
160 stars 57 forks source link

Detect github app ID for gitAuthor #269

Open natan-abolafya opened 1 year ago

natan-abolafya commented 1 year ago

These: image

Every PR created by renovate gets this comment on the next processing time. I am not sure when this exactly started but I am guessing after we started using "platformCommit":true. It seems to be due to git commit author getting a prefix of sort. So this might be a github setting issue but I am not sure where to look at.

Relevant debug log:

DEBUG: branch.isModified() = true (repository=appgate-sdp-int/ztp-adapter-scheduler, branch=renovate/peter-evans-create-or-update-comment-3.x)
       "branchName": "renovate/peter-evans-create-or-update-comment-3.x",
       "lastAuthor": "98109129+renovate-appgate[bot]@users.noreply.github.com",
       "gitAuthorEmail": "renovate-appgate[bot]@users.noreply.github.com"

So not sure where that 98109129+ comes from but I can see that on git also. I don't have the logs when the original PR was created unfortunately. But if you tell me what word to look for creating a new PR in the debug logs, I can hopefully dig up one.

rarkins commented 1 year ago

The number is your app's unique ID. If you configure gitIgnoredAuthors=98109129+renovate-appgate[bot]@users.noreply.github.com then it should go away. In future we can ideally automatically detect that.

natan-abolafya commented 1 year ago

ah, thanks. Should I close the issue or shall we leave this as a feature request for automatic detection?

rarkins commented 1 year ago

We can leave it open until it's automatically supported

nabeelsaabna commented 10 months ago

Hi @natan-abolafya this already handled started from release 6.0.0

dctrwatson commented 10 months ago

this already handled started from release 6.0.0

As of 6.2.0 the github app auto-detected gitAuthor is still missing the app id and requires adding it manually to gitIgnoredAuthors.

jamietanna commented 1 month ago

I believe this is now done on the 7.x releases?