Open jhoseph88 opened 2 months ago
Hey @jhoseph88 !
Thanks for pointing out the mismatch in the API docs and the node SDK responses. It looks like we need to update the JobStatusResponse to include the missing fields.
Would you be up for helping us fix this? Your assistance would greatly benefit everyone using the SDK. If you could also update the SDK's end-to-end tests to align with these changes, that would be perfect.
Let me know if you’re interested, or if there’s any other way I can assist.
@rafaelsideguide Pardon my delay! Absolutely--I've submitted https://github.com/mendableai/firecrawl/pull/391. I've had to mark these missing fields as optional because they periodically end up as undefined
in my local environment. I'll also point the following tests are failing for me locally:
should throw error for invalid API key on scrape
should throw error for invalid API key on crawl
should handle idempotency key for crawl
should throw error for invalid API key on search
This is likely due to my configuration.
Describe the Bug In the API docs, the
/crawl/status/{jobId}
advertises several parameters,current
,total
,current_step
, andcurrent_url
, not present in response via the node sdk. I am seeing onlydata
,partial_data
,status
, andsuccess
in the result forcheckCrawlStatus
. Would exposing this via JobStatusResponse be easy enough?To Reproduce Steps to reproduce the issue:
app
object withnew FirecrawlApp
app.crawlUrl(...
app.checkCrawlStatus(jobId);
withjobId
as the id of the job returned in the above crawl requestcurrent
,total
,current_step
, andcurrent_url
are missing from the responseExpected Behavior
current
,total
,current_step
, andcurrent_url
present in the response