🔥 Turn entire websites into LLM-ready markdown or structured data. Scrape, crawl and extract with a single API.
GNU Affero General Public License v3.0
17.39k
stars
1.26k
forks
source link
[Bug] timeout parameter not passed to playwright service #734
Closed
mschfh closed 1 week ago
Describe the Bug
The
timeout
parameter is not passed to playwright-service.To Reproduce Steps to reproduce the issue:
.env:
Send an API request:
Observe that the request sent to the microservice omits the
timeout
:The log displays an error with the default timeout of 15000ms:
Expected Behavior The timeout is passed to the playwright-service and used for
Page.goto
Additional Context The service expects a
timeout
parameter in the body: https://github.com/mendableai/firecrawl/blob/a40fb3b062dfee4d1dd79c4c4946f2f418da32c7/apps/playwright-service/main.py#L91-L95The playwright integration is not passing the parameter: https://github.com/mendableai/firecrawl/blob/a40fb3b062dfee4d1dd79c4c4946f2f418da32c7/apps/api/src/scraper/WebScraper/scrapers/playwright.ts#L38-L44
The suggested fix would be passing that parameter in the integration.