search

mendhak / gpslogger

:satellite: Lightweight GPS Logging Application For Android.
https://gpslogger.app
Other
2k stars 609 forks source link

Error Notification when URL send fails #1079

Open mikulik86 opened 1 year ago

mikulik86 commented 1 year ago

Hello, first of all thank you so much for this awesome app!

I just have a small request. Could you please add a Notification in case when sending to custom URL fails?

Thanks in advance.

mendhak commented 6 months ago

I'm currently working on error notifications for when permissions get revoked or files fail to write, which are pretty critical. So I thought I'd visit this issue while doing that.

The core part of implementing this was actually quite easy https://github.com/mendhak/gpslogger/commit/f0d886ae074bbba7eceb1ae97256280a56337fa1 but I've reverted it now for the below reasons.

But when testing it I found myself not 'getting' the importance. For reliability, the auto send feature is what should be used, which records a CSV file and uses that to re-issue requests. What's the purpose of knowing that the Custom URL send failed, and what would a user do about it? In the errors notification I want to keep noise to a minimum so I'd want the failure to be critical. In this case I feel there is a workaround so I'd like to hear more around this, maybe there's something I'm missing.