Closed utkarshkukreti closed 12 years ago
@utkarshkukreti, thanks for getting started on this. Unfortunately I don't think I'm going to have time to take a look at this before our Community week as I am away all next week.
Let's table this issue until then, and work through your questions on the 13th? Sound ok to you?
Sure, no problem :smile:
I think this is a good start. Very small design points, but I think they will make the highlight effect look better:
@sandal what do you think?
@jordanbyron I haven't pulled the latest code (only looked at the mockup), but those changes sound good to me.
@sandal great!
@utkarshkukreti I guess I should have answered the rest of your questions :wink2:
Is that the correct place to add the css code?
Since the css you've added is really generic, you might want to rename .highlight
to just .right
. I might already have that defined. It comes in handy anytime you need to right align an element.
Do you want me to add attr_accessible to the Article model to protect users from highlighting articles they cannot?
I don't think that is necessary, but if you can get it working without too much fuss then go ahead and do it.
I think that should be enough to get you on your way. Thanks again for working on this :bowtie:
Finished this up since it was so close to being done. Thanks @utkarshkukreti!
See #14
WIP. Opening pull request for discussion.