search

mendicant-original / community

Mendicant University's community website
community.mendicantuniversity.org
20 stars 10 forks source link

Add unread count in navigation #59

Closed samnang closed 12 years ago

samnang commented 12 years ago

See #26.

I've implemented a simple functionality by mark as read whenever users go to show page of [article | activity]. But I can't figure out to get it style. :smile:

jordanbyron commented 12 years ago

But I can't figure out to get it style.

That is not as hard as you might think. Do you want to take a stab at it yourself with a little guidance for me? Or would you rather finish up the functional work and pass the styling over to me? I'm fine with whatever you choose :smile:

samnang commented 12 years ago

@jordanbyron if I could get some guidance from you, I prefer to do it myself :smile:

jordanbyron commented 12 years ago

@samnang after reviewing this patch with @sandal I think it would be best for me to merge your changes in, make any updates / changes to the code, and then share what I did with you. I think that is better than going through line by line and giving you feedback. Hopefully I'll have something for you to look at by tomorrow. Then once we get this functional perhaps we can work on the styling together?

samnang commented 12 years ago

@jordanbyron sure, let's do it that way.

jordanbyron commented 12 years ago

@samnang all right I've done a ton of work on this feature. Check out the new unread_count branch I just pushed. It's close enough where we can start styling.

Let me know if you'd still like to work on that. Otherwise I'll take care of it myself. Also take a look at the changes I made and feel free to ask me any questions :smile:

I'm closing this pull request and we can discuss the styling on issue #26