search

mendicant-original / mentoring

9 stars 1 forks source link

Code review request (PuzzleNode) #46

Closed arvola closed 12 years ago

arvola commented 12 years ago

Greetings,

My name is Mikael (pronounced just Michael), and I would like to request a code review.

The code for review request consists of my solutions for PuzzleNode #13 and #15. One or both, and I have no preference as to which one. I have uploaded my solutions to Github: https://github.com/arvola/chess_validator https://github.com/arvola/poormans_forth

My expectation is fairly general: constructive criticism, insight into issues with the code and overall thoughts. My preference would be to have detailed discussion on a small number of topics rather than covering more of the code, but I welcome any and all insight!

I am generally extremely busy during the week, so Saturday and Sunday are best times for me. Preferably between 3 PM and Midnight CST (GMT -6). Either weekend in the next two weeks is fine.

Thank you very much for your time, I am looking forward to the review.

-Mikael

ericgj commented 12 years ago

Hi Mikael, How about this coming Sunday (Jan 29), at 5pm your time? Eric

arvola commented 12 years ago

Hi Eric,

Something came up that would make the next weekend better, Feb 4-5, if that works for you. I can still do this coming Sunday if it doesn't work though.

Thanks!

ericgj commented 12 years ago

Next weekend would also work for me, sure. Feb 5 at 5pm CST?

arvola commented 12 years ago

Sounds like a plan. Thanks!

ericgj commented 12 years ago

Hi Mikael, Just checking that we are still on for today? Still works for me at 5pm CST/ 6pm EST. Eric

arvola commented 12 years ago

Yup, still on. Talk to you then!

-Mikael

ericgj commented 12 years ago

ok, see you then, on #mendicant-study-hall-1 on freenode.

ericgj commented 12 years ago

Hi Mikael, good speaking with you the other week! Here's the transcript and etherpad from our session. Please feel free to sign up for another session any time, about your Poor Man's Forth or other code. And if you have a minute, we'd really appreciate some feedback (good or bad) here. Thanks!