practicingruby
commented
12 years ago @dtykocki,
I left a bunch of comments through your commit, but basically, here's what I'd like to see.
1) a single commit adding *.swp to the .gitignore
2) a commit which adds the following things
= A test/suite.rb file whose job is to explicitly require each test file, i.e:
require_relative "helper"
require_relative "units/server_test"
require_relative "units/controller_test"
#...= A test/helper.rb file which is exactly like the one you provided
= One stub file for each of newman's objects in test/units/object_name.rb which fails, i.e:
# in test/units/server_test.rb
require_relative "../helper"
describe Newman::Server do
it "should have tests" do
flunk
end
end= An updated gemspec which add purdytest
3) A feature patch which replaces some of the configuration open structs with ordinary Ruby objects that have a validate() method, and will raise an error when the required options are not set. Feel free to leave that to me if it's not clear what I'm looking for, though.
Thanks!
dtykocki
ericgj
This is my first open source commit, so any feedback is welcome!