search

mendicant-original / newman

Newman: a microframework for building email-based applications.
116 stars 11 forks source link

Add explicit RedCarpet dependency "~> 1.17.2" #38

Closed ezkl closed 12 years ago

ezkl commented 12 years ago

rocco depends on RedCarpet ~> 1.17.2. tilt doesn't specify the version. Mismatch causes the following error: can't activate redcarpet (~> 1.17.2), already activated redcarpet-2.1.0. Make sure all dependencies are added to Gemfile.

practicingruby commented 12 years ago

I removed the reference to rocco in our gemspec instead, because I don't want Newman to enforce a particular RedCarpet dependency and it seems we don't have an easier way to deal with this. This means those who want to document the generation locally will need to install the gem manually, but it should prevent Newman from being unable to be used with newer versions of RedCarpet in templates.

spraints commented 12 years ago

Why not put Rocco in newman's gemfile? Then, it's not forced on newman's users but it is available for developers.

practicingruby commented 12 years ago

@spraints, actually, that's a great idea. The Gemfile exists solely for developers anyway, so it's not so bad to lock to a particular version of Redcarpet there, especially since Newman doesn't use bundler at runtime. The end result should be that rocco will work as expected, but the development environment will still be able to use Redcarpet if needed.

If you want to try that out and see if it works, feel free to send a pull request for the Gemfile.