search

mendicant-original / newman

Newman: a microframework for building email-based applications.
116 stars 11 forks source link

Mail gem dependency issue #40

Closed alexw668 closed 12 years ago

alexw668 commented 12 years ago

Hi there,

We are looking at this newman gem and I think it can be useful for us. We are using Rails 3.2.2 which depends on the mail gem version 2.4.x; however, the gemspec of newman currently set to use mail 2.3.x, so bundler would have problem resolving the correct version for mail gem.

Is there any reason sticking to 2.3.x in newman? Can it use mail 2.4.x?

Thanks, Alex

ezkl commented 12 years ago

They changed the core implementation quite a bit between 2.3.x and 2.4.x: https://gist.github.com/2045510

practicingruby commented 12 years ago

Hi Alex,

There is a bug in Mail 2.4.x that needs to be fixed before we can upgrade. https://github.com/mikel/mail/pull/357

ericgj commented 12 years ago

Hi Alex, - just wanted to underline that newman is not ready for production use. But if you do try it out within rails, let us know how you get on with it. Probably you'll want to use server.tick rather than the wait loop, unless you run newman in a separate thread or something?

alexw668 commented 12 years ago

Thanks for your replies. So far we just put the operation in different thread.

alexw668 commented 12 years ago

Even though the issue related to the bug you mentioned was closed, the bug is still there!

practicingruby commented 12 years ago

@alexw668: Can you clarify on that? I asked Mikel to merge the patch today and he did, but AFAIK a new version of Mail has not been released yet. Did you try building Newman against Mail's master and still have a problem? Or did you just try running against the latest released version of Mail?

ezkl commented 12 years ago

Using Mail HEAD worked fine for me and also fixed the Gmail/IMAP issues I had during hackday.

practicingruby commented 12 years ago

@ezkl: Great. If you'd like to keep an eye on this issue, I'd accept an update to the gemspec that switches to 2.4.x once a new release is made. I will probably take a look myself before the next release, but if someone else investigates first that'll help me out :)

alexw668 commented 12 years ago

Yep, the Mail HEAD (with pull request #357 merged) works.