Indicate to admin/draft users which puzzles are unpublished

[gjp]

The standard puzzle index should flag unpublished puzzles in some way so it's clear which puzzles are hidden from non admin/draft users

[ptn]

I'm on it!

[ptn]

@jordanbyron would you prefer to have the unpublished puzzles marked as such in some way in the index view or a whole different view for them?

[jordanbyron]

Marked in the index. Probably with a simple graphic next in the same area where the solved check mark appears. Let me know if you need help finding a suitable graphic. I've collected many icon sets for things like this :wink2:

[ptn]

There we go. Here's a screenshot:

The first few commits aren't really about this discussion, they are just some very minor issues I stumbled upon that I fixed. The last commit (a3ff83a) is the one you'll want to cherry-pick if these other changes don't convince you.

[gjp]

I like the lock icon.

[jordanbyron]

@ptn the lock icon makes me think that puzzle is locked or not open to changes.What if we used simple yellow and green icons with title / alt text to indicate which puzzles are published / unpublished. Something like this:

Draft: Published:

They would only be visible to logged in users where User#draft_access or User#admin is true. How does that sound?

[ptn]

@jordanbyron I was trying to mark only the unpublished puzzles, since that introduces less noise to the page - Least Effective Difference, anyone?

I agree that the lock is not standard. The yellow dot is better, but I'm not sure how it would work without other puzzles having a green dot or a red dot. So what about a label then?

It's short and it clearly differentiates the two types of puzzles. Maybe the contrast is too harsh?

[ptn]

Yeah, definitely too harsh. Scratch that. Here's an update:

[jordanbyron]

I don't know I kinda like the big orange draft icons :wink2: I assume you're going to style those via CSS? If so ship the orange one and we can always change it to the more subtle dark blue later :smile:

[gjp]

My other two cents...I liked the lock because it got my attention, even though the symbolism wasn't quite right. So what does draft look like? :beer:?

I'd go for a higher contrast icon. If screamin' orange is too much, how about sampling the yellow out of the yellow dot?

[jordanbyron]

@ptn shoot over a pull request for this when it's ready :smile:

[ptn]

@jordanbyron lolwat? This is a pull request, this is the url I'm using: https://github.com/mendicant-university/puzzlenode/pull/47

[jordanbyron]

Ahahahahaha oh man. Don't mind me. Apparently I've finally gone crazy :wink2:

@ptn how did you turn @gjp's issue ticket into a pull request? I've never seen that happen before. It's like magic :sparkles:

[ptn]

@jordanbyron Using Chris Wanstrath's hub gem.

I set up remotes for your repo with name origin and my fork with name ptn (my username) and ran this command from my local branch: git pull-request -i 47 and Bingo was his name OH! Magic.

I don't know if there's UI to do that though. Maybe a quick dive into hub's source code will tell us that.

[gjp]

wait, wut? If you just did what I think you did, we should all be using this. Manually coordinating issues and pulls on the same topic really kind of sucks. Community post!

[ptn]

@gjp Roger that. One community post to go!