search

mendicant-original / puzzlenode

Quiz application inspired by Project Euler and the Internet Problem Solving Contest (IPSC)
puzzlenode.com
81 stars 43 forks source link

Update to Omniauth 1.x /wip #79

Closed wicz closed 12 years ago

wicz commented 12 years ago

Work in progress to update Omniauth to version 1.x so we can use the :sparkles: developer mode and ease the setup for new contributors. See #78

jordanbyron commented 12 years ago

@wicz wow it's crazy to see all the gems which omniauth < 1.0 required!

Anyway, a few issues we need to take care of. If you are too busy to take care of them let me know and I'll try to make the changes here.

1) Configuration files should never be checked in, which includes config/initializers/omniauth.rb. The change you made makes sense, but we need to gitignore that file and check in an example version.

2) Because of that change, we also need to update the README so new contributors know to copy that file into place.

3) By default, the omniauth developer login page doesn't include 'nickname' which we need to properly create a user. I added a tiny hack for that in community that we'll need to include here.

4) Changing SessionsController#new to just redirect to auth/#{provider} bypasses our "We're sending you to Github" page.

@sandal do you think that intermediate step is still necessary? What if we changed the login link to say "Log in with GitHub" like we do in Community and remove that intermediate page?

I'm really glad we are going this. Having the developer auth mode will make it much easier for new developers to get up and running. Thanks Vinicius :balloon:

wicz commented 12 years ago

Indeed, the number of gems required by the old omniauth is insane!

About 1) and 2) both are piece of cake, I can change them now.

I don't think we need to patch OmniAuth::Strategies::Developer anymore cause we can specify fields as arguments.

And I think we can get rid of the intermediate page for sake of simplicity :wink:

jordanbyron commented 12 years ago

I don't think we need to patch OmniAuth::Strategies::Developer anymore cause we can specify fields as arguments.

Awww man that is so cool! I knew there had to be a better way to do that. Thanks so much for pointing that out! Now I need to make that change in Community

wicz commented 12 years ago

That's it! Now we just need decide about 4)

practicingruby commented 12 years ago

@jordanbyron I think removing the intermediate page is OK.

jordanbyron commented 12 years ago

@wicz I'll take care of removing the intermediate page. Thanks for working on this! I should have time to merge this soon :smile: