search

mendicant-original / ruby

The Ruby Programming Language
http://www.ruby-lang.org/
Other
19 stars 8 forks source link

Documentation for Hash #7

Closed xenda closed 13 years ago

xenda commented 13 years ago

Adds some top level documentation on Hash, and some ideas on how it's often used. Would like some feedback on where to go from here/what to fix to prepare it as a patch.

semmons99 commented 13 years ago

Do you need help getting this patch created for submission to ruby-core?

xenda commented 13 years ago

If you think it could qualify as that, I'd give it a try. I've already experimented with using the git format-patch and see it creates a patch for each commit. Since I'm using several commits here, not sure what my strategy would be. I was thinking on collapsing all the commits on one and then create the patch.

semmons99 commented 13 years ago

Yeah. Rebase your commits into a single commit and then use git format-patch HEAD~1.

xenda commented 13 years ago

Thanks for your help clarifying that. Just did it and sent a ticket: http://redmine.ruby-lang.org/issues/5405. Let's hope for the best now :). Will try to do a couple more today.