search

mendix / EnumSlider

A slider based on your enumeration values
Apache License 2.0
0 stars 1 forks source link

Splice list fix (This fixes issue #1 on shott/EnumSlider) #2

Closed shott closed 9 years ago

shott commented 9 years ago

I believe that I have added a simple one-line (plus opening and closing brackets) change to EnumSlider.js that sorts spliceList into increasing numerical order of the indexes of this.slideEnum that should be removed.

I believe that this removes any order-dependence on the comma-separated string this.enumExceptions and, I believe, resolves the issue that I reported for this Widget as issue #1.

Note, I also apparently accidentally did a revert of "Added .gitignore". That must have been my pilot error. However, by doing a second revert of that action, I believe that it has been restored to its original condition. A apologize for that error and will hope to avoid such clumsiness in the future.

This was my first use of trying to add a branch to fix a problem in the Mendix GitHub set of widgets. If I did anything wrong or inappropriate, please do not hesitate to contact me directly at shott@stanford.edu.

Thanks,

John

RoelandSalij commented 9 years ago

Hi John, great feedback but function is mispelled. Could you please fix this?

shott commented 9 years ago

Roeland:

Oops, sorry for my typo. Spelling of function is corrected and commited in the file that I submitted. Is that all that I need to do?

Thanks,

John

On 12/16/2014 4:12 AM, Roeland Salij wrote:

Hi John, great feedback but function is mispelled. Could you please fix this?

— Reply to this email directly or view it on GitHub https://github.com/mendix/EnumSlider/pull/2#issuecomment-67150449.

RoelandSalij commented 9 years ago

I think you have to create a new pull request.

shott commented 9 years ago

Roeland:

OK, I think I've issued a new pull request. Sorry, I'm still new to this GitHub stuff.

John

On 12/16/2014 7:05 AM, Roeland Salij wrote:

I think you have to create a new pull request.

— Reply to this email directly or view it on GitHub https://github.com/mendix/EnumSlider/pull/2#issuecomment-67172392.

RoelandSalij commented 9 years ago

No problem, me too. :)