search

mendix / database-connector

https://appstore.home.mendix.com/link/app/2888/Mendix/Database-Connector
Apache License 2.0
9 stars 25 forks source link

Mx7.23 update #13

Closed pouyaist closed 5 years ago

dahfjkg commented 5 years ago

There is one thing from Augusto's comment that I cannot find in the MR: Add proper unit testing to check that the code rejects Float, Currency and HashedStrings as it should

pouyaist commented 5 years ago

There is one thing from Augusto's comment that I cannot find in the MR: Add proper unit testing to check that the code rejects Float, Currency and HashedStrings as it should

I updated his code to not through exception since we are removing the Float and Currency from Modeler. The user is unable to even create such a scenario.However, you need to check modeler for that, which is updated

dahfjkg commented 5 years ago

Reviewed the code + tested the changes together with Pouya. Approved ✅