search

mendix / database-connector

https://appstore.home.mendix.com/link/app/2888/Mendix/Database-Connector
Apache License 2.0
9 stars 25 forks source link

Upgrade database connector to version 8.6 #18

Closed Borzoo closed 4 years ago

basdebakker commented 4 years ago

Why the Mockito downgrade?

zubivan commented 4 years ago

@Borzoo do you think we can split it into 2 PRs? One to convert to 8 (basically one that takes care of conversion) and another one that converts to 8.6 and introduces typed template argument.

Update: Checked again, this PR actually just converts it to 8.6. Purely, because as a follow up we want to use features introduced in 8.6. This this conversion makes total sense.

The PR that uses the new API will follow.

Borzoo commented 4 years ago

@basdebakker

Why change Mockito version?

The tests were failing because of a null reference error somewhere in mockito library after upgrading to 8.6.

Why downgrade Mockito?

Seemed like the safest choice because it didn't have any dependencies, and it worked. In hindsight I think upgrading it would have been the better choice.

zubivan commented 4 years ago

LGTM from LC side.