fix: Added flow strip types transform

mendix / pluggable-widgets-tools

Moved to widget resources:

https://github.com/mendix/widgets-resources/

Apache License 2.0

8 stars 5 forks source link

Open cliedeman opened 4 years ago

cliedeman commented 4 years ago

@diego-antonelli I took a look around in webpack.config.common.js and I don't see a rule that compiles node_modules?

diego-antonelli commented 4 years ago

@cliedeman You should also include flow for the source code. Users can be able to use flow instead of typescript for example.

cliedeman commented 4 years ago

@diego-antonelli Sorry for the late reply.

Ah ok I see what you mean. I was only handling the case where there are flow types in react-native modules.

Will make the updates when I get a chance

cliedeman commented 4 years ago

@diego-antonelli updated

diego-antonelli commented 4 years ago

Hi @cliedeman nice! I will just test it over few cases and if everything succeed I'll merge it and inform you.

cliedeman commented 4 years ago

Thanks. Can you please try with react-native-router-flux. I could not get this one to work with the widget and it definitely does have flow types

cliedeman commented 4 years ago

We also tried the webpack customization notes but we got some weird errors trying to add a plugin. Will post some details soon