search

mengdiwang / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

Ensure that GWT artifacts are present in the Maven central repositories as part of release process. #501

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If you want to use Guava in a GWT project, you currently have to deploy the 
guava-r07-gwt.jar in your own Maven repository, as it's not on Maven Central.

Not a show stopper for us, but it would be much better if we weren't force to 
do it (and repeat it when we'll switch to r08)

Original issue reported on code.google.com by t.broyer on 17 Dec 2010 at 9:46

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 12 Jan 2011 at 10:02

GoogleCodeExporter commented 9 years ago 
I'll work on it this coming week.

Christian.

Original comment by cgruber@google.com on 13 Jan 2011 at 3:50

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 20 Jan 2011 at 6:56

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 27 Jan 2011 at 6:16

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 24 Mar 2011 at 2:24

GoogleCodeExporter commented 9 years ago 
Just checking, but should this really be marked fixed? I don't see any sign of 
the GWT jar in maven central.

Original comment by cgdec...@gmail.com on 24 Mar 2011 at 4:49

GoogleCodeExporter commented 9 years ago 
Christian, can you comment on this? I figure either it's already happened or it 
won't happen, as release 9 is on its way out the door now...

Original comment by fry@google.com on 24 Mar 2011 at 6:08

GoogleCodeExporter commented 9 years ago 
guava-gwt does not appear in any sub-folder of 
http://repo1.maven.org/maven2/com/google/guava/
What groupId/artifactId/version/classifier did you use ?

Original comment by alexandr...@gmail.com on 24 Mar 2011 at 6:16

GoogleCodeExporter commented 9 years ago 
I think at this point it would be fine if we could get this for r09 instead of 
r08. The main thing that's wanted here is the GWT jar in maven central and a 
way to ensure that happens for each release going forward.

Original comment by cgdec...@gmail.com on 24 Mar 2011 at 6:27

GoogleCodeExporter commented 9 years ago

Original comment by fry@google.com on 24 Mar 2011 at 6:32

GoogleCodeExporter commented 9 years ago 
<sigh>  Ok, if we're about to drop r09, then I'll fix it in trunk so we can 
release it all properly at the same time in the same process.

Original comment by cgruber@google.com on 24 Mar 2011 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by cgruber@google.com on 24 Mar 2011 at 9:52

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 8 Apr 2011 at 1:15

GoogleCodeExporter commented 9 years ago 
Any news on this ?

Original comment by christop...@gmail.com on 5 May 2011 at 11:43

GoogleCodeExporter commented 9 years ago 
We're re-organizing the build system and it should all be there in the next 
couple of weeks.

Can you help out by giving us a sense of HOW you use the gwt artifact?  At 
present, do you use the ant-built downloadable one as-is?  And do you use it 
via the maven GWT plugins, or how does it fit into your lifecycle?

Christian.

Original comment by cgruber@google.com on 5 May 2011 at 12:20

GoogleCodeExporter commented 9 years ago 
We're re-working the build system.  It should be in within the next couple of 
weeks.  Also, can you help describe how you use this artifact?  Using what 
plugins to consume it, etc.?

Original comment by christia...@gmail.com on 5 May 2011 at 12:21

GoogleCodeExporter commented 9 years ago 
Heh.  Forgot this wouldn't post to the bug. :)

Original comment by cgruber@google.com on 5 May 2011 at 12:26

GoogleCodeExporter commented 9 years ago 
We have an internal Artifactory Maven repo, so I simply downloaded the bundle 
from the Downloads page and deployed the guava-rXX-gwt.jar in the repository.
I deployed it with the same groupId and artifactId as Guava, using 
<classifier>gwt</classifier> to include it in our GWT modules; i.e.

  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
  </dependency>
  <dependency>
    <groupId>com.google.guava</groupId>
    <artifactId>guava</artifact>
    <version>${guava.version}</version>
    <classifier>gwt</classifier>
  </dependency>

I believe however that the *-gwt.jar should be done differently, using GWT's 
<super-source> to "redefine" the implementations when GWT-specific code is 
needed. GWT isn't terribly well integrated with Maven (or is it the other way 
around?), but what worked well for us (what we use for our own modules) is to 
simply use the classifier=sources dependency, and bundle the GWT-specific 
implementations as <super-source> inside it.

FYI, we used both the gwt-maven-plugin and maven-antrun-plugin to launch the 
GWT compiler. We only do launch the compiler from Maven; we launch GWT's 
DevMode from within Eclipse.

Do not hesitate to ask if you need to know more.

Original comment by t.broyer on 5 May 2011 at 12:38

GoogleCodeExporter commented 9 years ago 
@cgruber: responses inline:

> Can you help out by giving us a sense of HOW you use the gwt artifact?  
In short, we have 2 deps in our pom (just like t.broyer)

> At present, do you use the ant-built downloadable one as-is?  
Yes, but the gwt artifact by itself is not useful, the normal artifact is also 
required (see t.broyer comments about packaging of guava-gwt jar)

> And do you use it via the maven GWT plugins, or how does it fit into your 
lifecycle?
We use the maven-gwt-plugin to compile GWT client-side code and Google Eclipse 
Plugin to launch GWT's DevMode

I'll be watching this bug if you need any further comment, but for now it would 
be enough to deploy the r09 GWT artifact as-is to maven central.

Thanks

Original comment by diaz.sal...@gmail.com on 9 May 2011 at 12:39

GoogleCodeExporter commented 9 years ago 
Hi, any news on this? The guava-gwt artifacts are still not present in maven 
central. 
Thanks.

Original comment by hanrisel...@gmail.com on 9 Jun 2011 at 8:59

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 13 Jul 2011 at 6:18

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 16 Jul 2011 at 8:32

GoogleCodeExporter commented 9 years ago 
Any movement on this? We have a GWT library that we'd like to release to Maven 
Central, but can't because it depends on the guava-gwt artifacts (which aren't 
yet in Central).

Original comment by kelseyfr...@gmail.com on 2 Aug 2011 at 11:27

GoogleCodeExporter commented 9 years ago 
We're treating it as a release blocker this time.

Original comment by kevinb@google.com on 3 Aug 2011 at 3:10

GoogleCodeExporter commented 9 years ago 
What's keeping this from being released to Maven Central?  The artifact has 
already been created, which is typically the hard part.  Do you guys need help 
generating a pom.xml for it?  If there's anything I can do to help get this 
artifact into Maven Central, please let me know.

Original comment by chris.sh...@gmail.com on 15 Aug 2011 at 12:43

GoogleCodeExporter commented 9 years ago 
Would be much appreciated, it we could get this on central repo!

Original comment by sow...@gmail.com on 21 Aug 2011 at 12:13

GoogleCodeExporter commented 9 years ago 
Just can't wait for this...

Original comment by rafalwi...@gmail.com on 31 Aug 2011 at 1:13

GoogleCodeExporter commented 9 years ago 
These will be pushed when we push the release candidate.

Original comment by yrfselrahc@gmail.com on 6 Sep 2011 at 5:30

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:15

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:09