mengdiwang / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

Using consistent parameter name "errorMessage" instead of "desc" in Preconditions #512

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Most methods use the parameter name "errorMessage" for the error message but 
checkElementIndex()/checkPositionInex() names it "desc". Maybe this should be 
refactored to "errorMessage" too. Or does this have a reason?

Original issue reported on code.google.com by ullenb...@gmail.com on 4 Jan 2011 at 7:17

GoogleCodeExporter commented 9 years ago
That parameter isn't an error message, it's a description of what the index 
represents, which will be *used* as part of the constructed error message.

"@param desc the text to use to describe this index in an error message"

Original comment by kevinb@google.com on 12 Jan 2011 at 8:55

GoogleCodeExporter commented 9 years ago
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:15

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:09