search

mengyao / Complete-Striped-Smith-Waterman-Library

294 stars 112 forks source link

Please expose s_align.flag in the C++ wrapper #86

Closed marcelm closed 1 year ago

marcelm commented 1 year ago

The recently added flag attribute of the s_align struct is not exposed in the C++ wrapper.

After upgrading our copy of SSW, I noticed that we now sometimes get the message: "Warning: The alignment path of one pair of sequences may miss a small part." and an incorrect CIGAR (which does not match the query length). It appears that the s_align.flag attribute was added recently to signal failed alignments, but the C++ interface does not expose this, so in our case we cannot distinguish successful from failed alignments.

mengyao commented 1 year ago

s_align.flag will be the return value of c++ API Align function in the new release

marcelm commented 1 year ago

Nice, thanks a lot!