menhera-org / TabArray

Chrome-like tab groups using private and isolated containers: The ultimate tab manager and groups for Firefox.
https://addons.mozilla.org/firefox/addon/container-tab-groups/
GNU General Public License v3.0
125 stars 5 forks source link

opens duplicate tabs when set to "last active container" #411

Open anarcat opened 3 months ago

anarcat commented 3 months ago

Describe the bug Enabling this extension, under certain configurations, makes external applications (like firefox example.com from the commandline, or opening bookmarks) open links in two duplicate tabs instead of one.

To Reproduce Steps to reproduce the behavior:

  1. Enable the extension
  2. set the When an external application opens a tab setting to Open in last active container
  3. open a tab in a specific container (not the default one)
  4. open a bookmark in a new tab
  5. See two tabs opened instead of one

Expected behavior

Only a single tab should be open.

Screenshots

screenshot of the two tabs opened after clicking the middle button on a bookmark, with the extension inspector open:

image

Console outputs If applicable, open about:debugging > This Firefox and select Inspect for this extension. Then copy and paste what is in the console (you can hide your private information, if any).

from the screenshot above:


[background/background-redirector] Capturing request for tab 354: https://gitlab.torproject.org/groups/tpo/tpa/-/issues [popup-v2.613bc28f.js:1:29702](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
[background/BeforeRequestHandler] Redirecting https://gitlab.torproject.org/groups/tpo/tpa/-/issues to moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/navigation/confirm.html?urlId=2ac3981e034d06ba654749348b1a1b8e [popup-v2.613bc28f.js:1:29702](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
[background/background-redirector] Reopened https://gitlab.torproject.org/groups/tpo/tpa/-/issues in container id firefox-container-2 [popup-v2.613bc28f.js:1:29702](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
[background/background-redirector] Error: Invalid tab ID: 354 [popup-v2.613bc28f.js:1:29765](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
[background/ContainerVisibilityService] No tabs to show on window 1983 for cookie store firefox-default [popup-v2.613bc28f.js:1:29702](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
[background/TabSortingService] Tab sorting is already in progress. 2 [popup-v2.613bc28f.js:1:29702](moz-extension://91d95eb0-5822-4e2e-9c80-108b58bb0363/pages/popup-v2/popup-v2.613bc28f.js)
​```

If you cannot find any errors there, try opening the browser console (hamburger menu > more tools > browser console).

nothing added in the browser console.

**Firefox (please complete the following information):**

 - OS: Debian bookworm
 - Browser edition and version 115.12.0esr
 - Extension version 11.10.0.200

**Additional context**

I have many other extensions but managed to bisect the problem to this specific extension.. but it's possible it manifests itself only in combination with others.