menismu / popcorn-js

The HTML5 Media Framework
MIT License
202 stars 29 forks source link

Frame rate not passed when using .play() or .pause() #13

Open menismu opened 6 years ago

menismu commented 6 years ago

Issue reported: https://github.com/mozilla/popcorn-js/issues/345 Reported by: @MarkMurphy

On line 535 of the downloadable uncompressed version of popcorn.js Popcorn.util.toSeconds does not pass this.options.frameRate as a second argument.

The same is true for line 594 of the exec method.

EDIT: There are actually multiple calls to the toSeconds method from within popcorn where it doesn't pass the frameRate option and in addition to that, there are places where "framerate" is used instead of "frameRate"