search

menismu / popcorn-js

The HTML5 Media Framework
MIT License
202 stars 29 forks source link

Need an updated popcorn-complete.js #58

Open menismu opened 6 years ago

menismu commented 6 years ago

Issue reported: https://github.com/mozilla/popcorn-js/issues/467 Reported by: @steeevio

@steeevio steeevio commented on 18 Nov 2015 The latest version on the website is 1.5.6 but I think the youtube api fixes were put in after that. Is it possible to get version 1.5.11 somewhere? Or how can I go about building my own? Simply including the relevant plugin files and wrappers in my site is not working.

@jyxia jyxia commented on 4 Jan 2016 There is Makefile in this repo, so you can make it and build you own.

@NathanLawrence NathanLawrence commented on 27 Apr 2016 I agree with @jyxia - this should be made as needed to make sure it's not out of sync with the main codebase, not added to the repository.

@tinyengines tinyengines commented on 1 Feb 2017 Why? The project is dead - there should at least be a popcorn-complete.js and popcorn-complete.min.js for all those people who were linking to the now deprecated online versions.

titaniumbones commented 5 years ago

I agree with @tinyengines -- we should provide this. should be easy to add, do you want to do this? It only means that before committing to master, make build will have to be run.

tinyengines commented 5 years ago

I would absolutely love to - but I just don't have the time these days to contribute! Definitely wish you all the success and the glory - I'll be your first supporter!

CONFIDENTIALITY NOTICE : The contents of this email are confidential in nature and are intended for the sole use of the intended recipient. If you are not the intended recipient of this email, you have received this email in error. Any disclosure, distribution, copying or action taken in reliance on it is prohibited and may be unlawful.

On Tue, Mar 12, 2019 at 12:57 AM Matt Price notifications@github.com wrote:

I agree with @tinyengines https://github.com/tinyengines -- we should provide this. should be easy to add, do you want to do this? It only means that before committing to master, make build will have to be run.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/menismu/popcorn-js/issues/58#issuecomment-471627228, or mute the thread https://github.com/notifications/unsubscribe-auth/AWY-iF_ycJIRfwsvWIYBf7QrtDv749M-ks5vVor9gaJpZM4THJ2a .

titaniumbones commented 5 years ago

@menismu any rewsponse? only asking b/c I want to include popcorn libraries in an assignment next week -- I can use my own, but I'd love to link to official docs if various PR's can be merged. Any chance of that?

tinyengines commented 5 years ago

doubt it - was a mozilla project, that they deprecated years ago - if I'm not mistaken.

CONFIDENTIALITY NOTICE : The contents of this email are confidential in nature and are intended for the sole use of the intended recipient. If you are not the intended recipient of this email, you have received this email in error. Any disclosure, distribution, copying or action taken in reliance on it is prohibited and may be unlawful.

On Tue, Mar 12, 2019 at 11:31 PM Matt Price notifications@github.com wrote:

@menismu https://github.com/menismu any rewsponse? only asking b/c I want to include popcorn libraries in an assignment next week -- I can use my own, but I'd love to link to official docs if various PR's can be merged. Any chance of that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/menismu/popcorn-js/issues/58#issuecomment-472046869, or mute the thread https://github.com/notifications/unsubscribe-auth/AWY-iGPNo5h4sJWy447A5Dtt4EV8vVoTks5vV8g5gaJpZM4THJ2a .

titaniumbones commented 5 years ago

Yes, bu @menismu has taken over maintainership and has been working on it for the last year

titaniumbones commented 5 years ago

Probably developers should add a pre-commit hook that runs make build. cf https://github.com/ddddavidmartin/Pre-commit-hooks Will implement and add something to README when i have a chance.

vsoch commented 3 years ago

Any progress here? I'm looking for that same file - adding the plugins individually didn't work.

titaniumbones commented 3 years ago

I have a version of popcorn-complete.js that I can give you privately -- unfortunately it is not really ready for publication. I think @menismu has run out of time for this project, and I haven't been able to step up to maintain it myself properly. The code is getting a bit hard to read (lots of jQuery-style self-executing functions) and I'm not sure it's worth the effort to maintain it in its current form. Am definitely open to collaboration on updating if you're interested and have time/skills. I'd really like to reimplement hte lugins as say stencil components but I am not at the point where I'm ready to do that.

Hope that helps a little.