thematic_comment_class vs. comment_class

[GoogleCodeExporter]

New theme review requirement to use comment_class().

Currently we're using thematic_comment_class and it is found in discussion.php.

We could set a constant like the body class function to toggle ours or WP's 
function but I'm not sure if that's worth doing. 

I think thematic_comment_class() should be re-written to pass the $class param 
to comment_class(). That would happen in thematic_comments() . That's found in 
discussions.php

Original issue reported on code.google.com by eugene.m...@gmail.com on 26 Jan 2012 at 7:20

[GoogleCodeExporter]

i propose doing it exactly the same as for body class and deprecating 
thematic_comment_class, by allowed it to be added w/ add_theme_support() and 
filtering in the deprecated classes.  will probably want to do the same with 
post_class.  maybe we can't punt after all.  

Original comment by helgathe...@gmail.com on 26 Jan 2012 at 7:35

[GoogleCodeExporter]

switched thematic comments to use comment_class() with support for filtering in 
thematic's old thematic_comment_class() classes.  

for completeness, i went ahead and did the same thing w/ post_class()

Original comment by helgathe...@gmail.com on 27 Jan 2012 at 3:45

Attachments:

• discussion.php.diff
• dynamic-classes.php.diff
• content-extensions.php.diff

[GoogleCodeExporter]

switched thematic comments to use comment_class() with support for filtering in 
thematic's old thematic_comment_class() classes.  

for completeness, i went ahead and did the same thing w/ post_class()

Original comment by helgathe...@gmail.com on 27 Jan 2012 at 3:45

Attachments:

• discussion.php.diff
• dynamic-classes.php.diff
• content-extensions.php.diff

[GoogleCodeExporter]

r824

a fresh start

Original comment by eugene.m...@gmail.com on 2 Feb 2012 at 8:56

• Changed state: Fixed