mennake / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

add_theme_support and register_nav_menu must be in functions.php for theme review #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
add_theme_support('post-thumbnails');

and

register_nav_menu()

need to be in functions.php for theme review purposes

add_theme_support('automatic-feed-links’) does not appear to be required to 
be in functions.php but it may as well be.  i'm in favor of moving all the 
functions in init.php back to functions.php

Original issue reported on code.google.com by helgathe...@gmail.com on 26 Jan 2012 at 9:12

GoogleCodeExporter commented 9 years ago
moved to functions by way of moving all of init.php into functions.php

removed register_nav_menu from header-extensions.php

presumes the deletion of init.php

Original comment by helgathe...@gmail.com on 27 Jan 2012 at 4:03

Attachments:

GoogleCodeExporter commented 9 years ago
I'm for this in adherence of Theme Review guidelines. 

Chris? Thoughts this was your move originally.

Original comment by eugene.m...@gmail.com on 30 Jan 2012 at 1:02

GoogleCodeExporter commented 9 years ago
done in r833

Original comment by eugene.m...@gmail.com on 7 Feb 2012 at 12:47