mennake / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

thematic_postfooter_postcomments() reads # "Comments" for combined number of pings and comments #140

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In .entry-utility on loops, the total number of pings and comments to a post is 
listed (via thematic_postfooter_postcomments() ) as number of "comments".  but 
if it is 7 "comments" and 4 are pings, then really only 3 are comments.  should 
probably read "responses"

i'd put up a diff but i think i already have a lot of changes going on in 
content-extensions.php

Original issue reported on code.google.com by helgathe...@gmail.com on 27 Jan 2012 at 4:12

GoogleCodeExporter commented 9 years ago
Made a patch. Don't know how this will affect translations though, maybe they 
already use this kind of wording, maybe not. 

Original comment by invistr...@gmail.com on 30 Jan 2012 at 12:17

Attachments:

GoogleCodeExporter commented 9 years ago
It will probably have an impact. Many localizations will need to be updated. 

My only comment is that when you're making changes that do affect localized 
strings to try and change the output to remove leading and trailing white space 
and puncuation. 

See: Ticket 123

Original comment by eugene.m...@gmail.com on 30 Jan 2012 at 1:37

GoogleCodeExporter commented 9 years ago
Ah gotcha. Will do.

Original comment by invistr...@gmail.com on 30 Jan 2012 at 1:41

GoogleCodeExporter commented 9 years ago
Thanks. Gonna wait on committing this an lump it in with the other comment/ping 
issues

Original comment by eugene.m...@gmail.com on 30 Jan 2012 at 4:17

GoogleCodeExporter commented 9 years ago
r824

Original comment by eugene.m...@gmail.com on 2 Feb 2012 at 8:55