mennake / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

missing hooks for subsidiary widget areas #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Regarding the "missing" sidebar-subsidiary.php: 

 I see in the readme that this file was intentionally removed because the code is created through hooks. Well almost all. There is no thematic_abovesubasides and thematic_belowsubasides. I think we should either:

1) Bring back sidebar-subsidiary.php (Might be less confusing for child themers 
that all widgets areas have template files that can be overridden)

or
2) Add the hooks to thematic_subsidiaries() in footer-extensions:

function thematic_subsidiaries() {
    thematic_abovesubasides();
    widget_area_subsidiaries();
    thematic_abovesubasides();
 }

Original issue reported on code.google.com by invistr...@gmail.com on 30 Jan 2012 at 11:58

GoogleCodeExporter commented 9 years ago
made a patch for no2

Original comment by invistr...@gmail.com on 30 Jan 2012 at 12:06

Attachments:

GoogleCodeExporter commented 9 years ago
Good catch :)

r819

Original comment by eugene.m...@gmail.com on 30 Jan 2012 at 4:14