mennanov / fieldmask-utils

Protobuf Field Mask Go utils

MIT License

229 stars 26 forks source link

Add Go Modules and Options #10

Closed pbabbicola closed 4 years ago

pbabbicola commented 4 years ago

I found myself needing this feature and thought maybe I could get some feedback. Not my most elegant work but taking suggestions.

(Needs more testing still)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 58

55 of 56 (98.21%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 89.781%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
copy.go	55	56	98.21%
<!--	Total:	55	56	98.21%	-->

Totals
Change from base Build 53:	0.6%
Covered Lines:	369
Relevant Lines:	411

💛 - Coveralls

mennanov commented 4 years ago

Could you please extend the existing functions comments and briefly describe what the userOptions are for.

Also, i'm afraid we have to remove the go.mod and go.sum files from this pull request as the build fails in Travis: https://travis-ci.org/github/mennanov/fieldmask-utils/builds/691111125 (go modules can be added in a separate PR).

Thanks!

mennanov commented 4 years ago

It looks like this PR has nothing to do with the failing builds in Travis. I'll take a closer look into it soon.

codecov[bot] commented 4 years ago

Codecov Report

Merging #10 into master will increase coverage by 0.70%. The diff coverage is 83.67%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   86.33%   87.03%   +0.70%     
==========================================
  Files           2        2              
  Lines         300      324      +24     
==========================================
+ Hits          259      282      +23     
- Misses         22       23       +1     
  Partials       19       19

Impacted Files	Coverage Δ
copy.go	`81.40% <83.67%> (+1.97%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1705bfc...e7079f8. Read the comment docs.

pbabbicola commented 4 years ago

Could you please extend the existing functions comments and briefly describe what the userOptions are for.

Thanks for adding them! Sorry for the slowness on the replies/coding :)

mennanov commented 4 years ago

No worries, thanks for contributing!