mennanov / fieldmask-utils

Protobuf Field Mask Go utils
MIT License
229 stars 26 forks source link

Error introduced upgrading to bazel_rules_go #17

Closed shaneikennedy closed 3 years ago

shaneikennedy commented 3 years ago
com_github_mennanov_fieldmask_utils/copy.go:78:28: call of reflect.ValueOf copies lock value: google.golang.org/protobuf/types/known/anypb.Any contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

Ref: https://stackoverflow.com/questions/64183794/why-do-the-go-generated-protobuf-files-contain-mutex-locks

Sorry I don't know what other sort of context you need here, I'm getting this error in a build for some other service at my org when updating another dependency that then requires me to update bazel_rules_go. It's a mess.

If I can provide any more context please let me know. Although the error is happening because I'm upgrading some bazel package, the error looks to be a gRPC violation that became more strict in later versions.

mennanov commented 3 years ago

I've found and fixed the issue. Please, try this branch https://github.com/mennanov/fieldmask-utils/tree/issue17_fix and let me know if it works for you. If it does i'll merge it to the main branch.

mennanov commented 3 years ago

Closing the issue for now as the problem is resolved in the recent release https://github.com/mennanov/fieldmask-utils/releases/tag/v0.4.0